fix: use phoneNumber for socialLink in application

[MayankBansal12]

Date: 21-02-26

Developer Name: @MayankBansal12

---

Issue Ticket Number:-

• phoneNo field is being used for new application, however it was changed recently and API now accepts phoneNumber

Description:

• Update phoneNo to phoneNumber for new applications

Is Under Feature Flag

• Yes
• No

Database changes

• Yes
• No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

• Yes
• No

Is Development Tested?

• Yes
• No

Tested in staging?

• Yes
• No

Add relevant Screenshot below ( e.g test coverage etc. )

screencast

Screencast.from.2026-02-21.23-15-36.mp4

[cloudflare-workers-and-pages]

Deploying www-rds with    Cloudflare Pages

Latest commit:	0a00385
Status:	✅  Deploy successful!
Preview URL:	https://668bb24d.www-rds.pages.dev
Branch Preview URL:	https://fix-update-phoneno.www-rds.pages.dev

View logs

[coderabbitai]

Walkthrough

A systematic field rename from phoneNo to phoneNumber propagated across components, constants, and test fixtures. The change updates form data mapping, template bindings, validation schemas, and constant definitions to use the new field name consistently throughout the step four module.

Changes

Cohort / File(s)	Summary
New Join Step Components app/components/new-join-steps/base-step.js, app/components/new-join-steps/new-step-four.hbs, app/components/new-join-steps/new-step-four.js	Field rename from phoneNo to phoneNumber in form data mapping, template bindings, and validation schema. Updates form value references, error message bindings, and validation field keys.
Application Constants app/constants/applications.js, app/constants/new-join-form.js	Field name updated in exported socialFields array and NEW_STEP_LIMITS.stepFour validation configuration from phoneNo to phoneNumber.
Test Data tests/constants/application-data.js	Updated test fixture NEW_STEPS_APPLICATIONS_DATA.stepFour property name from phoneNo to phoneNumber.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A phone field hops from old to new,
From phoneNo to phoneNumber, through and through,
No logic breaks, just names refined,
Consistency restored, perfectly aligned! 📱✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: renaming phoneNo to phoneNumber across multiple files for socialLink field consistency.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description clearly explains the change: renaming 'phoneNo' to 'phoneNumber' because the API now expects the new field name for new applications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/update-phoneNo

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/constants/application-data.js (1)

30-38: ⚠️ Potential issue | 🟡 Minor

APPLICATIONS_DATA.socialLink is missing phoneNumber.

base-step.js's newStepFourData mapper now reads app.socialLink?.phoneNumber. Since this fixture has no phoneNumber key, any test that runs the mapper against APPLICATIONS_DATA will silently produce an empty phone number, bypassing form validation.

🛠️ Proposed fix

   socialLink: {
     github: 'johndoe',
     linkedin: 'johndoe',
     twitter: 'Johndoe',
     peerlist: 'johndoe',
     instagram: 'johndoe',
     dribbble: 'johndoe',
     behance: 'johndoe',
+    phoneNumber: '+1-699-969-6969',
   },

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/constants/application-data.js` around lines 30 - 38, The
APPLICATIONS_DATA fixture is missing socialLink.phoneNumber which causes
base-step.js's newStepFourData mapper (it reads app.socialLink?.phoneNumber) to
return empty and bypass form validation; update the APPLICATIONS_DATA.socialLink
object to include a realistic phoneNumber entry so tests exercising
newStepFourData get a populated phone value (locate APPLICATIONS_DATA.socialLink
in tests/constants/application-data.js and add the phoneNumber key).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@tests/constants/application-data.js`:
- Around line 30-38: The APPLICATIONS_DATA fixture is missing
socialLink.phoneNumber which causes base-step.js's newStepFourData mapper (it
reads app.socialLink?.phoneNumber) to return empty and bypass form validation;
update the APPLICATIONS_DATA.socialLink object to include a realistic
phoneNumber entry so tests exercising newStepFourData get a populated phone
value (locate APPLICATIONS_DATA.socialLink in
tests/constants/application-data.js and add the phoneNumber key).