fix: new infinite signup redirect for staging and development

[MayankBansal12]

Date: 15-01-26

Developer Name: @MayankBansal12

---

Issue Ticket Number:-

• fix: infinite redirect loop for new signup page when user has incompleteUserDetails=true #1132

Description:

• Adds extra check to avoid redirect if user is already on /new-signup

Is Under Feature Flag

• Yes
• No

Database changes

• Yes
• No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

• Yes
• No

Is Development Tested?

• Yes
• No

Tested in staging?

• Yes
• No

Add relevant Screenshot below ( e.g test coverage etc. )

screencast

Screencast.from.2026-01-15.02-31-37.mp4

[coderabbitai]

Walkthrough

Modified the development HOME URL from a root path to a subdomain-based configuration using existing environment variables, and augmented LoginService redirect logic to prevent redirects when users are on the '/new-signup' path, allowing them to complete signup without being redirected away.

Changes

Cohort / File(s)	Summary
URL Configuration app/constants/urls.js	Updated development HOME URL from '/' to subdomain-based URL leveraging SCHEME and DOMAIN constants
Login Service Redirect Logic app/services/login.js	Added conditional guard to suppress redirect to sign-up page when current path is '/new-signup', preserving user flow on that route

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• RealDevSquad/website-www#1115: Removes dev-gating and beforeModel redirect from '/new-signup' route, working in tandem with this PR's LoginService redirect suppression logic.

Suggested reviewers

• Hariom01010
• iamitprakash

Poem

🐰 A signup path, once prone to stray,
Now anchors users where they stay,
With HOME reborn through domains new,
The journey flows the proper way through! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'fix: new infinite signup redirect for staging and development' partially addresses the actual changes. While the PR does fix signup redirect logic and modifies URLs for development/staging, the word 'infinite' in the title is misleading—the PR fixes an infinite redirect issue rather than creating one, making the title ambiguous.	Revise the title to accurately reflect the fix, such as 'fix: prevent infinite signup redirect on /new-signup page' or 'fix: correct redirect logic and dev environment HOME URL' to clearly convey the issue being resolved.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description clearly relates to the changeset, describing the addition of a check to avoid redirect if the user is already on /new-signup, which matches the changes shown in login.js.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/login-redirect

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@app/services/login.js`:
- Around line 35-43: The code reads window.location.pathname and calls
window.location.replace() unguarded; wrap those accesses with the FastBoot guard
already injected on the service by checking this.fastboot.isFastBoot (or its
negation) before touching window. Concretely, only compute currentPath from
window.location.pathname and call window.location.replace(AUTH.SIGN_UP) when
this.fastboot.isFastBoot is false (and keep the existing conditions
user.incompleteUserDetails and !this.featureFlag.isDevMode); alternatively wrap
the entire redirect block (the currentPath variable, the conditional using
featureFlag.isDevMode, and the call to window.location.replace) in a
not-FastBoot check so server-side rendering won’t access window.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 126fd13 and 3004514.

📒 Files selected for processing (2)

• app/constants/urls.js
• app/services/login.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build (18.x)

🔇 Additional comments (1)

app/constants/urls.js (1)

36-36: LGTM, but note the mixed URL pattern in development config.

The change to use https://dev.realdevsquad.com for HOME aligns with the PR objective. This ensures AUTH.SIGN_UP resolves to a full URL, which is necessary for window.location.replace() to work correctly in the login service.

However, note that other development URLs (GOTO, EVENTS, PROFILE, IDENTITY, MY_STATUS) remain as relative paths while HOME is now absolute. This inconsistency is acceptable if intentional, but consider documenting this pattern or aligning all URLs for consistency in a future refactor.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[cloudflare-workers-and-pages]

Deploying www-rds with    Cloudflare Pages

Latest commit:	e18d24c
Status:	✅  Deploy successful!
Preview URL:	https://d68dbce9.www-rds.pages.dev
Branch Preview URL:	https://fix-login-redirect.www-rds.pages.dev

View logs

[MayankBansal12]

this login stub is required to prevent flaky behaviour for tests with login redirect and from browser timeout issues