Skip to content

Manage the styling of banner of both task update and standup update#648

Merged
ankushdharkar merged 3 commits intodevelopfrom
fix/banner
Jun 25, 2023
Merged

Manage the styling of banner of both task update and standup update#648
ankushdharkar merged 3 commits intodevelopfrom
fix/banner

Conversation

@Pratiyushkumar
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar commented Jun 21, 2023

Closes : #638

Description:

Manage the styling of the banner of both task update and standup update

Dev Tested:

  • Yes

Images/video of the change:

image
image

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 4:09pm

RitikJaiswal75
RitikJaiswal75 previously approved these changes Jun 21, 2023
Copy link
Contributor

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test with coverage screenshot

@Pratiyushkumar
Copy link
Contributor Author

Please add test with coverage screenshot

I have just worked on styling and for styling there are no test coverage

@Pratiyushkumar Pratiyushkumar requested review from sahsisunny and removed request for sahsisunny June 24, 2023 03:04
@Pratiyushkumar Pratiyushkumar dismissed sahsisunny’s stale review June 24, 2023 03:04

I have just worked on styling and for styling there are no test coverage

@sahsisunny
Copy link
Contributor

Why did you dismiss my REQUEST CHANGES? Without any proper reason don't delete or dismiss any review or comments please.

@sahsisunny
Copy link
Contributor

Please add test with coverage screenshot

I have just worked on styling and for styling there are no test coverage

You have made some changes in .tsx files so I think a test is needed.

Copy link
Contributor

@harshith-venkatesh harshith-venkatesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work handling all scenarios and explaining them

@ankushdharkar ankushdharkar merged commit e7d068a into develop Jun 25, 2023
@ankushdharkar ankushdharkar deleted the fix/banner branch June 25, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage the styling of banner of both task update and standup update

6 participants