Improve Dashboard Page of Status Site#636
Merged
RitikJaiswal75 merged 9 commits intodevelopfrom Jun 22, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shubham-y
reviewed
Jun 16, 2023
shubham-y
reviewed
Jun 16, 2023
shubham-y
previously approved these changes
Jun 17, 2023
bharati-21
reviewed
Jun 17, 2023
bharati-21
reviewed
Jun 17, 2023
bharati-21
reviewed
Jun 17, 2023
bharati-21
reviewed
Jun 17, 2023
bharati-21
reviewed
Jun 17, 2023
TanishqSingla
suggested changes
Jun 17, 2023
TanishqSingla
previously approved these changes
Jun 17, 2023
TanishqSingla
previously approved these changes
Jun 17, 2023
bharati-21
reviewed
Jun 17, 2023
Contributor
|
Apart from @bharati-21 comments things looks good. |
TanishqSingla
approved these changes
Jun 21, 2023
Contributor
Contributor
Author
hey @fakhruddinkw the designs will be taken up in the future once the design team gets us the design |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Title: Improve Dashboard Page of Status Site
issue: #581
Introduction
This pull request focuses on enhancing the Dashboard page of the Status Site project. It involves removing unused code, improving the responsiveness of the search bar component, and adding tests to ensure reliable functionality. The changes aim to improve the user experience and maintainability of the Dashboard page.
Feature Changes
Remove Unused Code:
Fix Responsive Search Bar Component:
Add enabled and disabled styles to the search button:
Add Tests:
Tech Stack
The implementation is based on the Next.js framework, utilizing its features and benefits for efficient development and rendering of the Status Site project.
Product Name
Status Site
Impact
The proposed changes will have the following impact:
Video before changes:
Screencast.from.16-06-23.04.44.06.PM.IST.mp4
Video after changes:
Screencast.from.17-06-23.01.40.21.PM.IST.mp4
Request for Feedback
Reviewers are kindly requested to provide feedback on the proposed changes. Specifically, we would appreciate insights on the effectiveness of unused code removal, the responsiveness of the search bar component, and the quality of the added tests. Additionally, any suggestions for further improvement are welcome.
Thank you for your time and valuable feedback.