refactored code to trigger less re-rendering#632
Conversation
|
@bksh05 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
Pratiyushkumar
left a comment
There was a problem hiding this comment.
I am approving it but please take care of my comment as well please
…s://github.com/bksh05/website-status into fix/stop-unnecessary-rerendering-of-issue-list
The base branch was changed.
RitikJaiswal75
left a comment
There was a problem hiding this comment.
Please put in the test coverage report, in case if there is none, please write them
@RitikJaiswal75 The test is above 85% of the component that I worked with. |
shubhamsinghbundela
left a comment
There was a problem hiding this comment.
Great work @bksh05
|
Are these multiple re-renders visible visually if yes please add a video of that, can you please add a video of changes after your code change |
Hey @RitikJaiswal75, I have updated the PR description that shows multiple re-renders when we type something in the search field. |




Issue:
Fix the code to render IssueList in /issues route.
Description:
On every input change on the search field, the issueList was being re-rendered. This was because the IssueList components was controlling the state of the SearchField component as well.
I fixed this issue by refactoring the code and moving the search field-related text to the SearchField component.
Fixes #605
Anything you would like to inform the reviewer about:
Dev Tested:
Images/video of the change:
Before the changes, the profiler shows it was re-rendered every time I typed something in the text box.

After the change, the profiler shows no re-rendering of the IssueList while changing the search field text
Follow-up Issues (if any)