added footer to task details page#631
Merged
prakashchoudhary07 merged 8 commits intoRealDevSquad:developfrom Jun 22, 2023
Merged
added footer to task details page#631prakashchoudhary07 merged 8 commits intoRealDevSquad:developfrom
prakashchoudhary07 merged 8 commits intoRealDevSquad:developfrom
Conversation
|
@bksh05 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
yesyash
requested changes
Jun 15, 2023
kotesh-arya
reviewed
Jun 15, 2023
Contributor
kotesh-arya
left a comment
kotesh-arya
left a comment
There was a problem hiding this comment.
Instead of using the navBarContent as a function expression we can replace it as a Functional component where ever it is used 👍🏻
yesyash
previously approved these changes
Jun 15, 2023
Contributor
Pratiyushkumar
left a comment
Pratiyushkumar
left a comment
There was a problem hiding this comment.
Request - please add a short video where tabs (task, issue, mine) are shown to be working fine just for reference of reviewers and future reference.
yesyash
approved these changes
Jun 21, 2023
kotesh-arya
approved these changes
Jun 22, 2023
shubhamsinghbundela
approved these changes
Jun 22, 2023
RitikJaiswal75
approved these changes
Jun 22, 2023
Merged
This was referenced Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
There was no footer on the task details page.
Description:
The task details page was missing the footer because the proper Layout was not being used.
Moved the Header code to a separate component.
Fixes #614
Anything you would like to inform the reviewer about:
N.A
Dev Tested:
Images/video of the change:
Before
After
footer_record.mp4
Follow-up Issues (if any)