Skip to content

Change fetch implementation to RTK Query for Idle Members#622

Merged
Ajeyakrishna-k merged 12 commits intoRealDevSquad:developfrom
Ajeyakrishna-k:develop
Jun 21, 2023
Merged

Change fetch implementation to RTK Query for Idle Members#622
Ajeyakrishna-k merged 12 commits intoRealDevSquad:developfrom
Ajeyakrishna-k:develop

Conversation

@Ajeyakrishna-k
Copy link
Contributor

@Ajeyakrishna-k Ajeyakrishna-k commented Jun 7, 2023

Issue: #513

Description:

currently are using Javscripts Fetch API for GET /members/idle, this PR replaces it with RTK query.

Anthing you would like to inform the reviewer about:

Dev Tested:

  • Yes

Images/video of the change:

Screenshot 2023-06-09 at 9 27 32 PM

Follow-up Issues (if any)

@Ajeyakrishna-k Ajeyakrishna-k self-assigned this Jun 7, 2023
@vercel
Copy link

vercel bot commented Jun 7, 2023

@Aryex82 is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add the data and screen-recorded output to the PR description, you PR description does not give any information to the reviewer

@Ajeyakrishna-k
Copy link
Contributor Author

Also please add the data and screen-recorded output to the PR description, you PR description does not give any information to the reviewer

As there was no change to UI in this PR I wasn't sure if a screenshot was necessary. I've added one now.

Pratiyushkumar
Pratiyushkumar previously approved these changes Jun 11, 2023
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bhtibrewal
bhtibrewal previously approved these changes Jun 13, 2023
Copy link
Contributor

@bhtibrewal bhtibrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pratiyushkumar
Pratiyushkumar previously approved these changes Jun 15, 2023
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bharati-21 bharati-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bharati-21 bharati-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts. Post that I'll approve.

Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bharati-21 bharati-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ajeyakrishna-k Ajeyakrishna-k merged commit 6f58f46 into RealDevSquad:develop Jun 21, 2023
@bhtibrewal bhtibrewal mentioned this pull request Jun 30, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants