fix : removed multiple user/self fetch#603
Merged
bhtibrewal merged 22 commits intoRealDevSquad:developfrom Jul 5, 2023
Merged
Conversation
|
@Shah-Arsalan is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
bhtibrewal
reviewed
Jun 4, 2023
bhtibrewal
reviewed
Jun 4, 2023
ep0ll
reviewed
Jun 6, 2023
Shah-Arsalan
commented
Jun 6, 2023
Pratiyushkumar
suggested changes
Jun 8, 2023
Contributor
Pratiyushkumar
left a comment
Pratiyushkumar
left a comment
There was a problem hiding this comment.
Please resolve merge conflict as well
Contributor
shubhamsinghbundela
left a comment
shubhamsinghbundela
left a comment
There was a problem hiding this comment.
Great work @Shah-Arsalan
Contributor
Pratiyushkumar
left a comment
Pratiyushkumar
left a comment
There was a problem hiding this comment.
Rest everything looks good to me
Pratiyushkumar
suggested changes
Jun 9, 2023
Contributor
Pratiyushkumar
left a comment
Pratiyushkumar
left a comment
There was a problem hiding this comment.
Please resolve above comments before asking for re-review
bhtibrewal
reviewed
Jun 13, 2023
bhtibrewal
reviewed
Jun 13, 2023
bhtibrewal
reviewed
Jun 13, 2023
Contributor
bhtibrewal
left a comment
bhtibrewal
left a comment
There was a problem hiding this comment.
Good work @Shah-Arsalan👏🏼 , left 2 small comments please look into those
bharati-21
reviewed
Jun 19, 2023
bharati-21
reviewed
Jun 19, 2023
bharati-21
reviewed
Jun 19, 2023
bharati-21
reviewed
Jun 19, 2023
bharati-21
reviewed
Jun 19, 2023
bharati-21
reviewed
Jun 19, 2023
…b.com/Shah-Arsalan/website-status into refactor/removing-multiple-user-fetch
bharati-21
reviewed
Jul 2, 2023
Shah-Arsalan
dismissed stale reviews from bhtibrewal, Pratiyushkumar, and bharati-21
via
51a12b3
kotesh-arya
previously approved these changes
Jul 4, 2023
kotesh-arya
approved these changes
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #582 remove the multiple users/self fetch
Description: The task is to remove the multiple use/self fetch calls and to abstract the logic for determining whether the user is authorized or not based on the fact whether user is admin or not.
I have made a custom hook to abstract the logic to determine whether the user is authorized or not
Dev Tested:
Implementation showed in video:
Before super user access :
withoutsuper.webm
After super user access :
withsuper.webm
Signin/Signout
screen-capture.webm