Skip to content

wrote tests+resolved queries#558

Merged
bhtibrewal merged 15 commits intoRealDevSquad:developfrom
sonai99:feature/challenges-rtk-query-tests
Jul 1, 2023
Merged

wrote tests+resolved queries#558
bhtibrewal merged 15 commits intoRealDevSquad:developfrom
sonai99:feature/challenges-rtk-query-tests

Conversation

@sonai99
Copy link
Contributor

@sonai99 sonai99 commented May 14, 2023

Wrote the RTK query for CHALLENGES_URL and replaced the useFetch implementation
Also wrote the test for it

image

image

@vercel
Copy link

vercel bot commented May 14, 2023

@sonai99 is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

@sonai99
Copy link
Contributor Author

sonai99 commented May 14, 2023

had to create a new PR with suggestions from the previous one + wrote the test
cc @bhtibrewal @Pratiyushkumar @kotesh-arya

bhtibrewal
bhtibrewal reviewed May 14, 2023
View reviewed changes
iamitprakash
iamitprakash reviewed May 14, 2023
View reviewed changes
@sonai99 sonai99 mentioned this pull request May 16, 2023
Closed
sonai99
sonai99 commented May 17, 2023
View reviewed changes
bhtibrewal
bhtibrewal reviewed May 17, 2023
View reviewed changes
bhtibrewal
bhtibrewal reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@bhtibrewal bhtibrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment everything else seems okay

sonai99
sonai99 commented May 20, 2023
View reviewed changes
Pratiyushkumar
Pratiyushkumar suggested changes May 20, 2023
View reviewed changes
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the test cases also

bhtibrewal
bhtibrewal previously approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@bhtibrewal bhtibrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work @sonai99 looks okay to me

Pratiyushkumar
Pratiyushkumar previously approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work @sonai99, looks good to me

@sonai99 sonai99 dismissed stale reviews from Pratiyushkumar and bhtibrewal via d5e94af May 22, 2023 12:54
@sonai99
Copy link
Contributor Author

sonai99 commented May 22, 2023

@bhtibrewal I have resolved the build fail
It was due to a check missing in the rtk query.

bhtibrewal
bhtibrewal previously approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@bhtibrewal bhtibrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

@sonai99
Copy link
Contributor Author

sonai99 commented Jun 1, 2023

@bhtibrewal can you please have a look at the latest commit.
Last time build failed due to the test failing, i have corrected it and its passing on local now.

@sonai99
Copy link
Contributor Author

sonai99 commented Jun 7, 2023

@bhtibrewal i have found a fix. Could you please have a look, i wanna see if the build fails or not.

@sonai99
Copy link
Contributor Author

sonai99 commented Jun 12, 2023

@bhtibrewal do i need to do anything more in this?
Build checks have passed

@sonai99
Copy link
Contributor Author

sonai99 commented Jun 18, 2023

@Pratiyushkumar Could you please have a look at this, its still awaiting approval. Not sure if i am required to do anything more on this.

Pratiyushkumar
Pratiyushkumar previously approved these changes Jun 18, 2023
View reviewed changes
@sonai99
Copy link
Contributor Author

sonai99 commented Jun 19, 2023

@Pratiyushkumar i have resolved the queries

Pratiyushkumar
Pratiyushkumar previously approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonai99
Copy link
Contributor Author

sonai99 commented Jun 21, 2023

@kotesh-arya / @shubhamsigdar1 can you please review this, need one more approval, its getting really delayed.

Pratiyushkumar
Pratiyushkumar approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonai99
Copy link
Contributor Author

sonai99 commented Jun 24, 2023

@iamitprakash / @bhtibrewal
General reminder that this PR is still awaiting approval.

@sonai99
Copy link
Contributor Author

sonai99 commented Jun 29, 2023

@bhtibrewal any reasons this hasn't been approved yet?
I got the approval from @Pratiyushkumar, just need one more.

@bhtibrewal bhtibrewal mentioned this pull request Jul 1, 2023
Open
17 tasks
bhtibrewal
bhtibrewal approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@bhtibrewal bhtibrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @sonai99

@bhtibrewal bhtibrewal merged commit 5837b62 into RealDevSquad:develop Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamitprakash iamitprakash Awaiting requested review from iamitprakash

2 more reviewers

@bhtibrewal bhtibrewal bhtibrewal approved these changes

@Pratiyushkumar Pratiyushkumar Pratiyushkumar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sonai99 sonai99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sonai99 @iamitprakash @bhtibrewal @Pratiyushkumar