Skip to content

standup feature page that takes standup of people and stores it#518

Merged
ankushdharkar merged 65 commits intoRealDevSquad:developfrom
Pratiyushkumar:feature/standup-feature
Jun 18, 2023
Merged

standup feature page that takes standup of people and stores it#518
ankushdharkar merged 65 commits intoRealDevSquad:developfrom
Pratiyushkumar:feature/standup-feature

Conversation

@Pratiyushkumar
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar commented Apr 26, 2023

###Parent Issue -
RealDevSquad/todo-action-items#134

Issue

create a page that takes standup op people and stores it
#486

What is the change?

A new standup Feature has been added to the status site

Is Development Tested?

  • Yes
  • No

Test cases are coming in the next issue
#604

Next issue -
#615

Before / After

standup-status-real-dev-squad-google-chrome-2023-06-03-14-33-52_INfX4aMB.mp4
standup-status-real-dev-squad-google-chrome-2023-06-03-14-44-28_TKwaalQM.mp4

Task Progress banner image -

image

@vercel
Copy link

vercel bot commented Apr 26, 2023

@Pratiyushkumar is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

@Pratiyushkumar Pratiyushkumar marked this pull request as ready for review April 26, 2023 13:12
@Pratiyushkumar Pratiyushkumar changed the title standup feature page that takes standup op people and stores it standup feature page that takes standup of people and stores it Apr 27, 2023
@Pratiyushkumar Pratiyushkumar self-assigned this Apr 27, 2023
Copy link

@vvaibhavdesai vvaibhavdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix all the comments and complete the PR before asking for a review

vvaibhavdesai
vvaibhavdesai previously approved these changes Jun 8, 2023
sahsisunny
sahsisunny previously approved these changes Jun 9, 2023
@Pratiyushkumar Pratiyushkumar requested review from iamitprakash and removed request for Muralidhar22, ankushdharkar, bhtibrewal and ivinayakg June 13, 2023 15:20
Copy link
Contributor

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it fast.....

@Pratiyushkumar Pratiyushkumar dismissed iamitprakash’s stale review June 18, 2023 14:04

Because he asked for test coverage and for test cases I have created another issue ticket.

@Pratiyushkumar Pratiyushkumar removed the request for review from iamitprakash June 18, 2023 14:04
@ankushdharkar ankushdharkar merged commit c3274f6 into RealDevSquad:develop Jun 18, 2023
@Pratiyushkumar Pratiyushkumar mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants