Skip to content

Fix OOO request approval/rejection flow for superusers and remove dev flag from request card #1020

@AnujChhikara

Description

@AnujChhikara

Issue Description

  • The functionality for approving or rejecting Out of Office (OOO) requests is currently broken.

  • As a result, there is no way for superusers to approve or reject OOO requests from the UI.

  • The card UI is not very good right now. We are not using newer card that is currently under feature flag

Expected Behavior

  • Superusers should be able to approve or reject OOO requests directly from the UI.

  • They should also have the option to add a comment while approving/rejecting a request.

  • New card that is under feature flag should be used for these actions

Current Behavior

  • Superuser can not approve/ reject the OOO requests

Required Changes

  • Update the OOO request acknowledge method from PUT to PATCH with dev = true.
  • Remove the dev flag from the newer requests card
  • Change the mapping of some field as response of the OOO requests have changed
  • Remove the dev flag from the OOO requests retrieval logic so that correct request fields are returned.
  • As that card has been used in onboarding requests then we are going to use the new card in onboarding also

Screenshots

Severity/Priority

  • Critical
  • High
  • Medium
  • Low

Additional Information

  • New Card design under feature flag
Image

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions