Adds route and controller for missed update user list api#1766
Merged
heyrandhir merged 11 commits intodevelopfrom Dec 13, 2023
Merged
Adds route and controller for missed update user list api#1766heyrandhir merged 11 commits intodevelopfrom
heyrandhir merged 11 commits intodevelopfrom
Conversation
Contributor
|
@Ajeyakrishna-k can you resolve the merge conflicts please. |
Ajeyakrishna-k
force-pushed
the
feat/missed-progress-routes
branch
from
cf06175 to
a71b3a6
Compare
Contributor
Author
Done! |
Ajeyakrishna-k
requested review from
bharati-21,
heyrandhir,
iamitprakash,
vikhyat187 and
vinayak-trivedi
iamitprakash
approved these changes
Dec 12, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ); | ||
| router.patch("/assign/self", authenticate, invalidateCache({ invalidationKeys: [ALL_TASKS] }), tasks.assignTask); | ||
|
|
||
| router.get("/users/discord", verifyCronJob, getUsersValidator, tasks.getUsersHandler); |
Check failure
Code scanning / CodeQL
Missing rate limiting
joyguptaa
approved these changes
Dec 13, 2023
Contributor
joyguptaa
left a comment
joyguptaa
left a comment
There was a problem hiding this comment.
LGTM. Please make sure of raising another PR where you have defined constants in upper and snake case.
ajoykumardas12
approved these changes
Dec 13, 2023
bharati-21
reviewed
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 9 Dec 2023
Developer Name: @Ajeyakrishna-k
Issue Ticket Number:-
Description:
Adds a route and controller function which returns discord Id of users who are active with tasks but have not filled in progress updates on task details page.
Docs:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Add relevant Screenshot below ( e.g test coverage etc. )