ts-migration: convert some routes from js to ts#1662
Merged
iamitprakash merged 14 commits intodevelopfrom Dec 27, 2023
Merged
Conversation
11 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import goals from "../controllers/goals"; | ||
| const router = express.Router(); | ||
|
|
||
| router.get("/token", authenticate, goals.getGoalSiteToken); |
Check failure
Code scanning / CodeQL
Missing rate limiting
11 tasks
…nd trading in typescript
| import { newTrade } from "../middlewares/validators/trading"; | ||
| import { trade } from "../controllers/trading"; | ||
|
|
||
| router.post("/stock/new/self", authenticate, newTrade, trade); |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
|
||
| const router = express.Router(); | ||
|
|
||
| router.patch("/user", validateUserRoles, authenticate, updateRoles); |
Check failure
Code scanning / CodeQL
Missing rate limiting
| import { notifyController } from "../controllers/notify"; | ||
| import { notifyValidator } from "../middlewares/validators/notify"; | ||
|
|
||
| router.post("/", authenticate, notifyValidator, notifyController); |
Check failure
Code scanning / CodeQL
Missing rate limiting
Ajeyakrishna-k
approved these changes
Dec 25, 2023
Contributor
|
Please add the issue number in description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Ticket Number:-
Description:
Change some files into typescript
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )