Skip to content

enhancement(todos): change pointer to cursor and underline title when hover on todo #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yesyash merged 1 commit into from
Jan 1, 2026
Merged

enhancement(todos): change pointer to cursor and underline title when hover on todo #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/todos/todo-list-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ const TodoListTableRow = ({
onSubmit={handleSubmit}
isMutationPending={mutation.isPending}
>
<TableCell className="whitespace-nowrap">{todo.title}</TableCell>
<TableCell className="whitespace-nowrap hover:cursor-pointer hover:underline">
{todo.title}
</TableCell>
Comment on lines +88 to +90
Copy link

@coderabbitai coderabbitai bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

LGTM! Hover styling correctly indicates interactivity.

The hover styles (cursor-pointer and underline) are properly applied to both edit and view mode TableCells, successfully achieving the PR objective of making todo titles visually interactive. The implementation is consistent across both branches.

Note: This same pattern is duplicated in src/modules/teams/team-tasks.tsx. Consider extracting a shared TodoTitleCell component if this pattern expands further.

Also applies to: 99-101

🤖 Prompt for AI Agents 
In src/components/todos/todo-list-table.tsx around lines 88-90 (and also
src/components/todos/todo-list-table.tsx lines 99-101 / similar pattern in
src/modules/teams/team-tasks.tsx), the hover styling for todo titles is
duplicated; extract a small reusable TodoTitleCell component that wraps its
children in a TableCell with className="whitespace-nowrap hover:cursor-pointer
hover:underline" (accepting children and any needed props like onClick), replace
the duplicated TableCell instances with this new component in both files, and
export the component where appropriate to keep behavior identical while removing
duplication.

</TodoDialog>
) : (
<TodoDialog
Expand All @@ -94,7 +96,9 @@ const TodoListTableRow = ({
onOpenChange={setShowViewTodoModal}
open={showViewTodoModal}
>
<TableCell className="whitespace-nowrap">{todo.title}</TableCell>
<TableCell className="whitespace-nowrap hover:cursor-pointer hover:underline">
{todo.title}
</TableCell>
</TodoDialog>
)}
<TableCell className="whitespace-nowrap">
Expand Down
8 changes: 6 additions & 2 deletions src/modules/teams/team-tasks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ const TodoListTableRow = ({ todo, team }: TodoListTableRowProps) => {
onSubmit={handleSubmit}
isMutationPending={mutation.isPending}
>
<TableCell className="whitespace-nowrap">{todo.title}</TableCell>
<TableCell className="whitespace-nowrap hover:cursor-pointer hover:underline">
{todo.title}
</TableCell>
Comment on lines +61 to +63
Copy link

@coderabbitai coderabbitai bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

LGTM! Consistent hover styling applied.

The hover styles are correctly implemented and match the changes in src/components/todos/todo-list-table.tsx, ensuring a consistent user experience across both user and team dashboards.

Note: The TodoListTableRow component in this file shares significant logic with the one in src/components/todos/todo-list-table.tsx. Consider extracting a shared component to reduce duplication and improve maintainability.

Also applies to: 72-74

</TodoDialog>
) : (
<TodoDialog
Expand All @@ -67,7 +69,9 @@ const TodoListTableRow = ({ todo, team }: TodoListTableRowProps) => {
onOpenChange={setShowViewTodoModal}
open={showViewTodoModal}
>
<TableCell className="whitespace-nowrap">{todo.title}</TableCell>
<TableCell className="whitespace-nowrap hover:cursor-pointer hover:underline">
{todo.title}
</TableCell>
</TodoDialog>
)}
<TableCell className="whitespace-nowrap">
Expand Down