fix(todo-list-table): update include done tasks toggle logic #175
fix(todo-list-table): update include done tasks toggle logic #175
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Summary by CodeRabbit
WalkthroughA new boolean constant is introduced in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this shark.
(`.
\ `.
) `._..---._
\`. __...---` o )
\ `._,--' , ___,'
) ,-._ \ ) _,-'
/,' ``--.._____\/--''Files scanned
| File Path | Reviewed |
|---|---|
| components/todo-list-table.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
components/todo-list-table.tsx (1)
220-231: Ensure Switch is controlled with a boolean to avoid controlled/uncontrolled warnings.
includeDoneis optional; when undefined the Switch may become uncontrolled. Coerce to boolean.Apply this diff:
- <Switch + <Switch id="includeDoneTasks" - checked={includeDone} + checked={!!includeDone} onCheckedChange={(checked) => onIncludeDoneChange?.(!!checked)} />Optional: If this component can appear multiple times on a page, consider using a unique id via
useId()for theid/htmlForpair to avoid collisions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
components/todo-list-table.tsx(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: shubhdevelop
PR: Real-Dev-Squad/todo-frontend#35
File: components/SimmerSkeleton.tsx:0-0
Timestamp: 2025-03-16T10:34:22.088Z
Learning: The shimmer component in the todo app should maintain the app's color palette (white, indigo-50) without making colors configurable, as it's designed specifically for this application.
…ects boolean value
5 participants
Date: 8 Aug 2025
Developer Name: @AnujChhikara
Issue Ticket Number
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
Note
I'm currently writing a description for your pull request. I should be done shortly (<1 minute). Please don't edit the description field until I'm finished, or we may overwrite each other. If I find nothing to write about, I'll delete this message.
Description by Korbit AI
What change is being made?
Update the logic for displaying the 'Include Done Tasks' toggle by using the
showIncludeDoneTasksTogglevariable to check for the current tab.Why are these changes being made?
This change ensures the 'Include Done Tasks' toggle is visible when the user is viewing either the 'All' tab or when no specific tab is selected, improving user experience by consistent handling of the toggle across relevant views without dependency on directly referencing the specific tab.