Skip to content

fix: labels not rendering in the watchlist task tab#129

Merged
prakashchoudhary07 merged 1 commit intodevelopfrom
fix/watchlist-tab-labels
Jul 18, 2025
Merged

fix: labels not rendering in the watchlist task tab#129
prakashchoudhary07 merged 1 commit intodevelopfrom
fix/watchlist-tab-labels

Conversation

@AnujChhikara
Copy link
Contributor

@AnujChhikara AnujChhikara commented Jul 18, 2025

Date: 18 July 2025

Developer Name: @AnujChhikara


Issue Ticket Number

Description

  • fix the issue where labels are not showing in the watchlist task tab

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1 image

Test Coverage

Screenshot 1

Additional Notes

Description by Korbit AI

What change is being made?

Update the labels type in TWatchListTask from string[] to TLabel[] and render labels using TodoLabelsList component in the tasks table.

Why are these changes being made?

The change ensures that task labels in the watchlist are correctly typed and rendered using a dedicated component. This change addresses the issue of labels not displaying properly by ensuring they are managed consistently across the dashboard components.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

@coderabbitai
Copy link

coderabbitai bot commented Jul 18, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • New Features
    • Improved display of task labels in the dashboard by showing detailed label information instead of just label names.
    • Enhanced label rendering in task tables using a dedicated label list component for a clearer and more consistent presentation.

Walkthrough

The labels property in the TWatchListTask type was changed from an optional array of strings to an optional array of TLabel objects. Corresponding updates were made in dashboard components to handle and render the richer label data using the TodoLabelsList component and to pass actual label data instead of empty arrays.

Changes

File(s) Change Summary
api/tasks/tasks.types.ts Changed TWatchListTask.labels type from string[] to TLabel[].
modules/dashboard/components/dashboard-tasks-table.tsx Switched label cell rendering to use TodoLabelsList with the full labels array.
modules/dashboard/components/dashboard-watchlist-tasks-table.tsx Updated formattedTasks to assign task.labels instead of an empty array.

Sequence Diagram(s)

sequenceDiagram
    participant DashboardWatchlistTasksTable
    participant DashboardTasksTable
    participant TodoLabelsList

    DashboardWatchlistTasksTable->>DashboardTasksTable: Pass formattedTasks with labels: TLabel[]
    DashboardTasksTable->>TodoLabelsList: Render labels using labels: TLabel[]
    TodoLabelsList-->>DashboardTasksTable: Rendered labels
Loading

Possibly related PRs

  • #126: Introduces and uses a richer Label type for task labels, directly related to the type change in TWatchListTask.
  • #115: Expands TWatchListTask with a labels field as { name: string }[], relating to similar type and property modifications.

Suggested reviewers

  • iamitprakash

Poem

In the garden of tasks, a label did grow,
Once just a string, now richer in tow.
With TLabel arrays, our tasks are adorned,
Components rejoice, no longer forlorn.
🐇✨
Code hops ahead, ever tidy and bright—
Labels in bloom, what a beautiful sight!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

api/tasks/tasks.types.ts

Oops! Something went wrong! :(

ESLint: 9.30.1

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.5_eslint-plugin-import-x@4.16.1_@typescript-eslint+utils@8.36.0_79fa352f41e97200dfc66b7389b5a599/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.

modules/dashboard/components/dashboard-tasks-table.tsx

Oops! Something went wrong! :(

ESLint: 9.30.1

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.5_eslint-plugin-import-x@4.16.1_@typescript-eslint+utils@8.36.0_79fa352f41e97200dfc66b7389b5a599/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.

modules/dashboard/components/dashboard-watchlist-tasks-table.tsx

Oops! Something went wrong! :(

ESLint: 9.30.1

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.5_eslint-plugin-import-x@4.16.1_@typescript-eslint+utils@8.36.0_79fa352f41e97200dfc66b7389b5a599/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc1b1a9 and 588e7cd.

📒 Files selected for processing (3)
  • api/tasks/tasks.types.ts (1 hunks)
  • modules/dashboard/components/dashboard-tasks-table.tsx (2 hunks)
  • modules/dashboard/components/dashboard-watchlist-tasks-table.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AnujChhikara AnujChhikara self-assigned this Jul 18, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this dinosaur.

            __
           / _)
    .-^^^-/ /
 __/       /
<__.|_|-|_|
Files scanned
File Path Reviewed
modules/dashboard/components/dashboard-watchlist-tasks-table.tsx
api/tasks/tasks.types.ts
modules/dashboard/components/dashboard-tasks-table.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@AnujChhikara AnujChhikara changed the title refactor: update task labels handling in dashboard Watchlist components fix: labels not rendering in the watchlist task tab Jul 18, 2025
@prakashchoudhary07 prakashchoudhary07 merged commit 8efcb7e into develop Jul 18, 2025
3 of 4 checks passed
@prakashchoudhary07 prakashchoudhary07 deleted the fix/watchlist-tab-labels branch July 18, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants