Skip to content

Comments

feat: update task status handling and integrate into forms and component#127

Merged
iamitprakash merged 1 commit intodevelopfrom
feat/add-task-status-input
Jul 18, 2025
Merged

feat: update task status handling and integrate into forms and component#127
iamitprakash merged 1 commit intodevelopfrom
feat/add-task-status-input

Conversation

@AnujChhikara
Copy link
Contributor

@AnujChhikara AnujChhikara commented Jul 18, 2025

Date: 18 July 2025

Developer Name: @AnujChhikara


Issue Ticket Number

Description

  • Renamed TASK_STATUS_ENUM value from 'COMPLETED' to 'DONE' for consistency.
  • Added status field to CreateEditTodoForm, allowing users to select task status.
  • Updated EditTaskButton to handle status updates when editing tasks.
  • Enhanced TodoStatusTable to reflect the new status naming convention.
  • Integrated status handling in CreateTodoButton for task creation.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

Note

I'm currently writing a description for your pull request. I should be done shortly (<1 minute). Please don't edit the description field until I'm finished, or we may overwrite each other. If I find nothing to write about, I'll delete this message.

Description by Korbit AI

What change is being made?

Refactor task status handling by changing the COMPLETED status to DONE, and integrate the task status enum into forms and components across the codebase.

Why are these changes being made?

The refactoring is aimed at improving consistency and clarity in task status labels by renaming COMPLETED to DONE to align it with common terminology used in task management contexts. Integrating the task status enum into forms and components ensures proper handling and validation of task statuses throughout the application.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

…ents

- Renamed TASK_STATUS_ENUM value from 'COMPLETED' to 'DONE' for consistency.
- Added status field to CreateEditTodoForm, allowing users to select task status.
- Updated EditTaskButton to handle status updates when editing tasks.
- Enhanced TodoStatusTable to reflect the new status naming convention.
- Integrated status handling in CreateTodoButton for task creation.
@coderabbitai
Copy link

coderabbitai bot commented Jul 18, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • New Features

    • Added the ability to set and update the status of a task when creating or editing, with options including "Todo", "In Progress", and "Done".
  • Improvements

    • Updated task status terminology from "Completed" to "Done" throughout the app for consistency.
    • The task status now appears in relevant forms and tables with updated labels.

Walkthrough

The changes update the task status enum by renaming "COMPLETED" to "DONE" and propagate this update throughout the codebase. The task form schema and UI are extended to support an editable task status, and the task creation and editing flows are updated to handle the new status field.

Changes

File(s) Change Summary
api/tasks/tasks.enum.ts Renamed enum member COMPLETED to DONE in TASK_STATUS_ENUM with updated string value.
components/create-edit-todo-form.tsx Added optional status field to form schema and UI; integrated status selection in the form.
components/edit-task-button.tsx Included status in form initialization and update payload for editing tasks.
components/todo-status-table.tsx Updated status mapping from COMPLETED/"Completed" to DONE/"Done".
modules/dashboard/components/create-todo-button.tsx Included status in the payload when creating a new task.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TaskForm
    participant Backend

    User->>TaskForm: Opens create/edit task form
    TaskForm->>User: Shows fields including status (Todo, In Progress, Done)
    User->>TaskForm: Fills form and selects status
    TaskForm->>Backend: Submits task data with status
    Backend-->>TaskForm: Confirms task creation/update
    TaskForm-->>User: Updates UI with new status
Loading

Possibly related PRs

  • Real-Dev-Squad/todo-frontend#98: Both PRs modify the task status enum value from "COMPLETED" to "DONE" and update the corresponding status option in the task form component to reflect this change.

Suggested reviewers

  • iamitprakash

Poem

In the garden of code, a task once "Completed,"
Now hops along as "Done," so neatly repeated.
Status in forms, a bunny’s delight,
With enums and fields all working just right.
🐇 Tasks leap forward—what fun in the sun!
The code is refreshed, and the work is well done!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/edit-task-button.tsx

Oops! Something went wrong! :(

ESLint: 9.30.1

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.5_eslint-plugin-import-x@4.16.1_@typescript-eslint+utils@8.36.0_79fa352f41e97200dfc66b7389b5a599/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.

api/tasks/tasks.enum.ts

Oops! Something went wrong! :(

ESLint: 9.30.1

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.5_eslint-plugin-import-x@4.16.1_@typescript-eslint+utils@8.36.0_79fa352f41e97200dfc66b7389b5a599/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.

components/create-edit-todo-form.tsx

Oops! Something went wrong! :(

ESLint: 9.30.1

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.5_eslint-plugin-import-x@4.16.1_@typescript-eslint+utils@8.36.0_79fa352f41e97200dfc66b7389b5a599/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.

  • 2 others

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5448d5a and 2f5bb53.

📒 Files selected for processing (5)
  • api/tasks/tasks.enum.ts (1 hunks)
  • components/create-edit-todo-form.tsx (4 hunks)
  • components/edit-task-button.tsx (2 hunks)
  • components/todo-status-table.tsx (1 hunks)
  • modules/dashboard/components/create-todo-button.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Readability Unnecessary Comment ▹ view
Files scanned
File Path Reviewed
api/tasks/tasks.enum.ts
components/todo-status-table.tsx
modules/dashboard/components/create-todo-button.tsx
components/edit-task-button.tsx
components/create-edit-todo-form.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

/>
</div>

{/*status*/}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary Comment category Readability

Tell me more
What is the issue?

The comment 'status' adds no value and doesn't follow the capitalization pattern of other section comments.

Why this matters

Inconsistent or redundant comments can create noise and make code harder to scan.

Suggested change ∙ Feature Preview

Remove the comment entirely as the code is self-documenting through its field label.

Provide feedback to improve future suggestions

Nice Catch Incorrect Not in Scope Not in coding standard Other

💬 Looking for more details? Reply to this comment to chat with Korbit.

@iamitprakash iamitprakash merged commit 75c2f04 into develop Jul 18, 2025
3 of 4 checks passed
@iamitprakash iamitprakash deleted the feat/add-task-status-input branch July 18, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants