[Live-Site] Add 100ms sdk to join room & Screen share #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanketDhabarde
changed the title
SanketDhabarde
changed the title
satyam73
requested changes
Jun 4, 2023
Deploying with
|
| Latest commit: |
4370714
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cacd9434.www-rds.pages.dev |
| Branch Preview URL: | https://491-live-site-add-the-join-f.www-rds.pages.dev |
satyam73
approved these changes
Jun 5, 2023
SanketDhabarde
changed the title
SanketDhabarde
changed the title
satyam73
approved these changes
Jun 11, 2023
| @@ -18,6 +19,7 @@ export default class LiveController extends Controller { | |||
| @tracked name = ''; | |||
| @tracked isJoined = false; | |||
| @tracked role = null; | |||
| @globalRef('videoEl') videoEl; | |||
There was a problem hiding this comment.
NIT : remove this unused declaration
rohan09-raj
approved these changes
Jun 11, 2023
rohan09-raj
deleted the
491-live-site-add-the-join-functionality-in-live-share
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Join the 100ms room
Closes #491, #447
What is the change?
We integrated 100ms to join the live session and share the screen by the host. The API which is used to get the token or join the room will be replaced with the backed APIs when they are ready.
Is Development Tested?
Before / After Change Screenshots
Join
join-fun.mp4
Screenshare
ss.mp4