[Ember-Migration] Created a navbar #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
e58c303
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e42ce9cf.www-rds.pages.dev |
| Branch Preview URL: | https://feat-navbar.www-rds.pages.dev |
rohan09-raj
requested review from
prakashchoudhary07,
lakshayman and
vinayak-trivedi
prakashchoudhary07
requested changes
Dec 1, 2022
prakashchoudhary07
approved these changes
Dec 6, 2022
|
NIT: .gitkeep within the controllers, route, and model can be removed, We have one on the root level, that should be enough I think |
|
Why is build failing? |
Will remove all the .gitkeep in another PR, as the code is still progressing and folders are being filled out with files |
It is due to the CI failing because of the old GitHub workflow. I have mentioned in the description also as a `Note for the reviewer |
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 8, 2022
* Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes
rohan09-raj
added a commit
that referenced
this pull request
Dec 10, 2022
* Created a navbar * minor refactoring and fixes * Created header component * created description component * resolved over simplications and minor fixes * Created a navbar * minor refactoring and fixes * Created a navbar * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * minor fixes * Removed repetition of code * removed redundant image
rohan09-raj
added a commit
that referenced
this pull request
Dec 13, 2022
* Created a navbar * minor refactoring and fixes * Created header component * created description component * resolved over simplications and minor fixes * created cards * made cards and modals responsive * minor fix * Created a navbar * minor refactoring and fixes * Created a navbar * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * minor fixes * Removed repetition of code * removed console logs * added escape click functionality * moved data to a constants file
rohan09-raj
added a commit
that referenced
this pull request
Dec 15, 2022
* Created a navbar * minor refactoring and fixes * Created header component * created description component * resolved over simplications and minor fixes * created cards * made cards and modals responsive * minor fix * created more about component * Created a navbar * minor refactoring and fixes * Created a navbar * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * minor fixes * Removed repetition of code * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * created more about component * minor fix
rohan09-raj
added a commit
that referenced
this pull request
Dec 16, 2022
* Created a navbar * minor refactoring and fixes * Created header component * created description component * resolved over simplications and minor fixes * created cards * made cards and modals responsive * minor fix * created more about component * created scroll to top button * Created a navbar * minor refactoring and fixes * Created a navbar * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * minor fixes * Removed repetition of code * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * created more about component * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * removed redundant code
rohan09-raj
added a commit
that referenced
this pull request
Dec 18, 2022
* Created a navbar * minor refactoring and fixes * Created header component * created description component * resolved over simplications and minor fixes * created cards * made cards and modals responsive * minor fix * created more about component * created scroll to top button * CI updated and made minor fixes in PR template * Created a navbar * minor refactoring and fixes * Created a navbar * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * minor fixes * Removed repetition of code * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * created more about component * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * removed redundant code
rohan09-raj
added a commit
that referenced
this pull request
Dec 29, 2022
* Created a navbar * minor refactoring and fixes * Created header component * created description component * resolved over simplications and minor fixes * created cards * made cards and modals responsive * minor fix * created more about component * created scroll to top button * Created a navbar * minor refactoring and fixes * Created a navbar * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * minor fixes * Removed repetition of code * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * created more about component * [Ember-Migration] Created a navbar (#325) * Created a navbar * minor refactoring and fixes * resolved over simplications and minor fixes * removed redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue
Closes #288
What is the change?
Is Development Tested?
Before / After Change Screenshots
Note for the Reviewer