changes in backend to accommodate new number input field in join section #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakhruddinkw
requested review from
RitikJaiswal75,
prakashchoudhary07 and
vinayak-trivedi
sahsisunny
reviewed
Mar 23, 2023
sahsisunny
reviewed
Mar 23, 2023
prakashchoudhary07
requested changes
Mar 24, 2023
prakashchoudhary07
requested changes
Mar 26, 2023
prakashchoudhary07
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes : #961
Changes made:
-Added the new numberOfHours field in joi schema, as a number field with min=1 and max=100 and set to required.
-before validating made sure numberOfHours from req.body was converted to integer, because if we dont do this it will fail the validation
-Also added the numberOfHours to addJoinData controller function to sent the data to DB.
-made sure the sent numberOfHours field was number by parsing it.