Dev to Main Sync #2363
Merged
Dev to Main Sync #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main to Dev sync
* feat: add pagination to GET /progreses API * fix returning 404 on a page with no data * fix joi validator logic * refactor getting totalcount logic * fix dev true * fix merge conflicts * using constant * maked the JsDoc more concise --------- Co-authored-by: Vinit khandal <111434418+vinit717@users.noreply.github.com>
* added test for the get progresses pagination * added test for dev=false * minor fix * added unit test for utils/progresses functions * added progressed model unit tests * added test for 500 * added 500 message from constant * fix test naming
…approval or rejection (#2334) * feat: Add feature to update request before approval or rejection - Add common validator to redirect request based on type of extension - Add type field in onboarding extension validator - Import addLog from services to make it available for stubbing while testing - Moved response messages to constants file - Reuse single instance of current date in request and log model for consistent data - Change controller name - Remove unused variables - Add authorization check for superuser or request ownership - Change authorization condition - Remove unnecessary changes * fix: add logs for failure cases and fix check for same old and new deadline * refactor: separate validation and update logic in service file * chore: fix jsDoc * fix: send id instead of while request doc while updating it * chore: fix lint issue * fix: change validation response condition and fix jsDoc * fix: add strict checking * fix: change constant message
…requests (#2335) * feat: Add test cases for controller and validator - Remove failing tests and fix existing tests - Add tests to check success and unexpected behaviour and fix existing tests - Replace actual messages with constants for easily maintenance - Add test for super user and request owner authorization check and fix existing failing tests - Remove un-necessary changes - Remove separate file for validator tests * feat: add tests for onboarding update and validate service
Fix flaky test present in PR[2335]
Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com> Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com>
iamitprakash
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
20th January, 2025Developer Name: @pankajjs @AnujChhikara
Issue Ticket Number
PR going for Sync
idquery parameter in Get Requests API #2367Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Working Proof of onboarding extension request's edit feature
Staging proof of pagination of progresses API
Staging proof of id query working in get request api endpoint
staging_id.mp4
Test Coverage
Screenshots
Additional Notes