Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unverified role to db and remove on /verify #2257

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Add unverified role to db and remove on /verify #2257

merged 8 commits into from
Dec 3, 2024

Conversation

shobhan-sundar-goutam
Copy link
Contributor

@shobhan-sundar-goutam shobhan-sundar-goutam commented Nov 18, 2024 •
edited
Loading

Date: 19-11-2024

Developer Name: Shobhan Sundar Goutam

Issue Ticket Number

Description

When a new user joins Discord, they are assigned an "Unverified" role/tag. However, this role is currently not stored in the database for tracking. The goal is to update the system so that this "Unverified" role is stored in the database as well. When a user completes the /verify command and authorizes themselves, the "Unverified" role should be removed from both the Discord and the database. Also respective logs are stored during this process.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
store-delete-unverified-db.mp4

Test Coverage

Screenshot 1

image
image

image
image

@pankajjs
Copy link
Member

Left few comments @shobhan-sundar-goutam

@pankajjs
Copy link
Member

@shobhan-sundar-goutam
Copy link
Contributor Author

Build is failing and it very weird for me. Not done anything that will make the build fail especially in the second commit.

Not under feature flag because each parts are either getting triggered from frontend, discord slash command or cron-job. So putting under feature flag would require handling feature flags in the respective places from where the apis are getting called and these are already getting used in production which will result in breaking the entire flow. Also staging and prod test will become a big issue in that case.

@shobhan-sundar-goutam shobhan-sundar-goutam force-pushed the feat/add-unverified-role-tracking branch from aefead1 to 6bdc786 Compare November 21, 2024 14:15
Achintya-Chatterjee
Achintya-Chatterjee reviewed Nov 21, 2024
View reviewed changes
controllers/users.js Outdated Show resolved Hide resolved
test/unit/utils/remvoeDiscordRoleFromUser.test.js Outdated Show resolved Hide resolved
@shobhan-sundar-goutam shobhan-sundar-goutam force-pushed the feat/add-unverified-role-tracking branch from fc1afe4 to d8027cf Compare November 24, 2024 21:57
@shobhan-sundar-goutam shobhan-sundar-goutam force-pushed the feat/add-unverified-role-tracking branch from cec8e58 to 6e8b5be Compare November 30, 2024 18:22
@iamitprakash iamitprakash merged commit 74f8324 into Real-Dev-Squad:develop Dec 3, 2024
3 checks passed
@Achintya-Chatterjee Achintya-Chatterjee mentioned this pull request Dec 5, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajjs pankajjs pankajjs approved these changes

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

Assignees

@shobhan-sundar-goutam shobhan-sundar-goutam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store "Unverified" Role in Database on User Join and Remove upon Verification
4 participants
@shobhan-sundar-goutam @pankajjs @Achintya-Chatterjee @iamitprakash