Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for LZMA-enabled artifacts #428

Merged
merged 5 commits into from
Jun 2, 2015
Merged

add support for LZMA-enabled artifacts #428

merged 5 commits into from
Jun 2, 2015

Conversation

dicej
Copy link
Member

@dicej dicej commented Apr 7, 2015

No description provided.

@sgoings
Copy link
Contributor

sgoings commented Apr 7, 2015

I'd like to use something other than curl to grab those files... maybe: https://github.com/michel-kraemer/gradle-download-task?

Also the failure looks like we need to take a look at how we're handling the win32/win64 artifacts/dependencies in the build.gradle. Oops! Looks like you fixed it.

@dicej
Copy link
Member Author

dicej commented Apr 8, 2015

The latest failure is a spurious failure of the Trace test, which we've seen before (and which used to go unnoticed back before #416 got fixed). It seems to fail maybe 1% of the time. I'll enter a new issue for that, but I'm sure it's not a regression related to this change.

@joshuawarner32
Copy link
Collaborator

Sorry, I didn't notice this had just been sitting around. @sgoings - can you force-push something to this branch to trigger the build again, just for my own comfort? This'll do it nicely: git checkout sgoings; git commit --amend --no-edit; git push -f. FWIW, I spent tried to reproduce the trace failure both on my mac host, and a linux VM, to no avail (I left Joel's script in #429 running for a couple hours).

joshuawarner32 added a commit that referenced this pull request Jun 2, 2015
add support for LZMA-enabled artifacts
@joshuawarner32 joshuawarner32 merged commit b6ed0e9 into master Jun 2, 2015
@joshuawarner32
Copy link
Collaborator

Sorry, I didn't notice this hanging out. My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants