fix case of JNIEnv::FindClass called from JNI_OnLoad #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an JNI_OnLoad implementation calls FindClass when using the OpenJDK class library, the calling method on the Java stack will be ClassLoader.loadLibrary. However, we must use the class loader of the class attempting to load the library in this case, not the system classloader. Therefore, we now maintain a stack such that the latest class to load a library in the current thread is at the top, and we use that class whenever FindClass is called by ClassLoader.loadLibrary (via JNI_OnLoad). Note that this patch does not attempt to address the same problem for the Avian or Android class libraries, but the same strategy should work for them as well.
|
If it's not too hard, I'd like to see this expanded to the avian class library and a test added. |
|
Yup, I'll work on that when I have a chance. |
|
I've added a test and verified it passes with avian, android, openjdk, and openjdk-src builds. |
…ibraries This also fixes the some Android build rot and updates the version of OpenSSL used.
joshuawarner32
added a commit
that referenced
this pull request
Jul 2, 2014
fix case of JNIEnv::FindClass called from JNI_OnLoad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an JNI_OnLoad implementation calls FindClass when using the OpenJDK
class library, the calling method on the Java stack will be
ClassLoader.loadLibrary. However, we must use the class loader of the
class attempting to load the library in this case, not the system
classloader.
Therefore, we now maintain a stack such that the latest class to load
a library in the current thread is at the top, and we use that class
whenever FindClass is called by ClassLoader.loadLibrary (via
JNI_OnLoad).
Note that this patch does not attempt to address the same problem for
the Avian or Android class libraries, but the same strategy should
work for them as well.
Fixes #277