expand: fixes and tests #788
Conversation
Add subscription assertions on expand tests. Add concurrency-related tests.
Fix expand() in order to emit each next value only once. It was previously emitting those values multiple times when a concurrency limit was set.
: 👍 I was hitting while I try to add test coverage for this operator, hadn't look in detail at the moment. |
|
btw, huge PR combos :)
|
|
😎 |
| return Observable.empty(); | ||
| } | ||
| return cold(e2shape, { z: x + x }); | ||
| }, concurrencyLimit); |
There was a problem hiding this comment.
how does concurrency limit ignorance works when it's delivered as param of expand compare to other cases where it delivers and expect to honor those limit?
There was a problem hiding this comment.
I meant that if the concurrency limit is high enough, then the behavior should be the same as not specifying it at all (which means Infinity). It's important to test because there is an if statement that only runs when the parameter is finite. We want to be sure "very big number" works the same as "infinite".
There was a problem hiding this comment.
understood. thought not passed means explicitly skips concurrency limits.
|
In general change looks good to me. |
Fix expand() in order to emit each next value only once. It was previously emitting those values
multiple times when a concurrency limit was set.
Add subscription assertions on expand tests. Add concurrency-related tests.