fix(fromEvent): improve typings for JQueryStyleEventEmitter #6091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes the rebased commits from #5584. Something happened when I pushed the rebased changes to that dev's branch and GitHub seemed to closed the PR. I don't recall closing it myself. After that, it wouldn't let me reopen the PR without additional commits being added and denied me the permission to push an additional, empty commit. WTF?
Anyway, the changes from that PR are here. It had been languishing for a while and the changes LGTM.
What? There's nothing in this PR?
It seems the changes where (somehow? perhaps inadvertently?) included in this PR: #5783
Related issue (if exists): #5584