Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(UI): upgrade to Angular CLI V6 #4032

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Aug 17, 2018

Description:

Updates docs app dependencies for Angular CLI, Material and framework

Related issue (if exists):

@rxjs-bot
Copy link

Warnings
⚠️

❗ Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Aug 17, 2018

Coverage Status

Coverage increased (+0.2%) to 96.947% when pulling ff65796 on brandonroberts:docs_app-upgrade-deps into 5fc893c on ReactiveX:master.

Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW, this is an awesome PR, thank you so much! I checked it locally and everything is still working, only thing, could you remove: docs_app/tools/examples/shared/package-lock.json from this pr, because for now we don't have these live examples and until then we don't need the package-lock for the examples

@brandonroberts
Copy link
Contributor Author

Done

Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much!

@cartant cartant merged commit 030eee7 into ReactiveX:master Aug 19, 2018
@brandonroberts brandonroberts deleted the docs_app-upgrade-deps branch August 20, 2018 03:50
@lock lock bot locked as resolved and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants