fix(onErrorResumeNext): no longer holds onto subscriptions too long #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
---6.1KB-green.svg?style=flat-square){kind=icon}
---0.6KB-green.svg?style=flat-square){kind=icon}
|
|
||
| protected _error(err: any): void { | ||
| this.subscribeToNextSource(); | ||
| if (sources.length === 1 && isArray(first)) { |
There was a problem hiding this comment.
Is there any perf win/loss if we avoid the above variable allocations by moving this before the destructure assigment, and use isArray(sources[0])?
There was a problem hiding this comment.
It would probably be a slight perf loss, as you'd need to look up first by index twice.
david-driscoll
approved these changes
Feb 2, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the size of onErrorResumeNext.
Fixes an issue where
onErrorResumeNextwas holding onto all inner subscriptions for the lifetime of the resulting observable.Updates documentation
related #2459
closes #3178