Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): revert to 5.4.x build output for CJS & add configurable s… #2878

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

jasonaden
Copy link
Collaborator

…upport for ESM

I had attempted to make a fully non-breaking change where we resolve modules through a package.json file (one package.json file for every module distributed). As it turns out, this doesn't work due to differences between case sensitive and insensitive file systems (and TypeScript configuration options to make case insensitive file systems resolve files with case sensitivity).

This PR makes the basic output the same as it was previously. But it adds distribution of ESM5 and ESM2015 build artifacts. It also dynamically generates a file that can be imported and used in Webpack to resolve to the ESM distribution.

Usage looks like this:

// webpack.config.js

const path = require('path');
const rxPaths = require('rxjs/_esm5/path-mapping');

var config = {
  resolve: {
    alias: rxPaths(path.resolve(__dirname, 'node_modules'))
  }
}

@rxjs-bot
Copy link

Messages
📖

CJS: 1341.6KB, global: 739.6KB (gzipped: 138.7KB), min: 146.0KB (gzipped: 31.2KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.477% when pulling b44c06c on jasonaden:revert_package_changes into e8d8c08 on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Oct 2, 2017

This should close #2876

@benlesh benlesh merged commit 167456a into ReactiveX:master Oct 2, 2017
@benlesh benlesh mentioned this pull request Oct 2, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants