Update to TypeScript 2.1, Update Errors, Breaking Changes! #2606

benlesh · 2017-05-17T20:48:15Z

Breaking Changes!!

Updates to TS 2.1
Eliminates duplicate class helpers in every CJS output file
adds tslib
No longer exporting any Error subclasses, rather there are utility functions to create Errors, and to test if an error is a specific type.
Requires that Symbol is properly shimmed

benlesh · 2017-05-17T20:49:16Z

I'm honestly not entirely sure I did this properly, but the tests are running okay, and I don't see the duplicate __extends methods in the build output.

cc @IgorMinar @kwonoj

kwonoj · 2017-05-17T20:50:51Z

In my blur memory our global build did manually import tslib something similar while bundling via rollup, not sure if it still exists and need to be updated?

coveralls · 2017-05-17T20:56:42Z

Coverage increased (+0.0003%) to 97.735% when pulling 74a875d on benlesh:noEmitHelpers into cf88a20 on ReactiveX:master.

benlesh · 2017-05-17T21:57:48Z

@kwonoj are you talking about this?

I honestly don't remember what that's doing or why. :\ If no one remembers, I guess I'll have to dig in.

kwonoj · 2017-05-17T22:00:51Z

@benlesh yes, these 3 are history of those .

#2064
#2093
#2121

kwonoj

@benlesh so looking basically it looks harmless to global build (it was using tslib already) but only need to update https://github.com/benlesh/RxJS/blob/74a875d15ca5d3d89588dba94b6f47e1b772fc07/package.json#L192 this, should remove duplication as new change makes tslib to dependencies.

IgorMinar · 2017-05-19T17:20:49Z

src/Rx.ts

@@ -1,4 +1,6 @@
 /* tslint:disable:no-unused-variable */
+import 'tslib';


is this just so that we bring in the helpers for the umd file?

IgorMinar · 2017-05-19T17:21:36Z

tsconfig.json

 {
  "compilerOptions": {
+    "importHelpers": true,
+    "noEmitHelpers": true,


I don't think that you need noEmitHelpers, importHelpers should be sufficient.

IgorMinar · 2017-05-19T17:23:19Z

package.json

-    "compile_dist_es6_for_docs": "tsc ./dist/es6/src/Rx.ts ./dist/es6/src/add/observable/of.ts ./dist/es6/src/MiscJSDoc.ts -m es2015   --sourceMap --outDir ./dist/es6 --target ES6 -d --diagnostics --pretty --noImplicitAny --noImplicitReturns --noImplicitThis --suppressImplicitAnyIndexErrors --moduleResolution node",
-    "cover": "shx rm -rf dist/cjs && tsc src/Rx.ts src/add/observable/of.ts -m commonjs --lib es5,es2015.iterable,es2015.collection,es2015.promise,dom --outDir dist/cjs --sourceMap --target ES5 -d && nyc --reporter=lcov --reporter=html --exclude=spec/support/**/* --exclude=spec-js/**/* --exclude=node_modules mocha --opts spec/support/default.opts spec-js",
+    "compile_dist_cjs": "tsc ./dist/cjs/src/Rx.ts ./dist/cjs/src/add/observable/of.ts -m commonjs --lib es5,es2015.iterable,es2015.collection,es2015.promise,dom --noEmitHelpers --sourceMap --outDir ./dist/cjs --target ES5 -d --diagnostics --pretty --noImplicitAny --noImplicitReturns --noImplicitThis --suppressImplicitAnyIndexErrors --moduleResolution node",
+    "compile_module_es6": "tsc ./dist/es6/src/Rx.ts ./dist/es6/src/add/observable/of.ts -m es2015  --noEmitHelpers  --sourceMap --outDir ./dist/es6 --target ES5 -d --diagnostics --pretty --noImplicitAny --noImplicitReturns --noImplicitThis --suppressImplicitAnyIndexErrors --moduleResolution node --noEmitHelpers --lib es5,es2015.iterable,es2015.collection,es2015.promise,dom ",


is this right? shouldn't this be importHelpers?

🤷‍♂️

What I found online said noEmitHelpers. I'll try it the other way around.

imcotton · 2017-05-20T18:53:13Z

tsconfig.json

@@ -1,5 +1,7 @@
 {
  "compilerOptions": {
+    "importHelpers": true,


importHelpers requires TypeScript v2.1

Noted, thanks... I'm going to attempt to update TS...

Sadly, that makes this a breaking change. :(

rxjs-bot · 2017-05-24T17:33:05Z

	Fails
🚫	missing type definition import in tests (skipLast-spec.ts) (1)

(1) : It seems updated test cases uses test scheduler interface hot, cold but miss to import type signature for those.

Generated by 🚫 dangerJS

staltz · 2017-05-24T17:48:35Z

Don't fear the major number ;)

- adds `tslib` import to `Rx.ts` - adds `--noEmitHelpers` to build output closes #2605

BREAKING CHANGE: The following types no longer exist: `EmptyError`, `UnsubscriptionError`, `ArgumentOutOfRangeError`, `ObjectUnsubcribedError`, `TimeoutError`, `AjaxError`, `AjaxTimeoutError`. There are now utilities for creating and testing under `Rx.Util` for example: `Rx.Util.createTimeoutError()` and `Rx.Util.isTimeoutError(err)` etc. closes #2612 related #2582

tslib updated to 1.7

benlesh · 2017-05-24T20:28:40Z

FWIW: I move that this can be the first RxJS 6 alpha or beta once merged, and we can start looking at merging some of the other changes for the next major sitting in our queue. As long as the breaking changes aren't too fast.

benlesh · 2017-05-25T17:15:47Z

Closing in favor of #2614

lock · 2018-06-06T09:41:21Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

benlesh added the Next Minor Version label May 17, 2017

benlesh requested a review from kwonoj May 17, 2017 20:49

kwonoj previously requested changes May 18, 2017

View reviewed changes

IgorMinar reviewed May 19, 2017

View reviewed changes

imcotton suggested changes May 20, 2017

View reviewed changes

refactor(Rx): stop duplicating TS class helpers in each CJS file

c990b4a

- adds `tslib` import to `Rx.ts` - adds `--noEmitHelpers` to build output closes #2605

benlesh added Next Major Version and removed Next Minor Version labels May 24, 2017

benlesh added 2 commits May 24, 2017 13:24

chore(tslib): update tslib to 1.7.*

33b0ffc

benlesh changed the title ~~refactor(Rx): stop duplicating TS class helpers in each CJS file~~ Update to TypeScript 2.1, Update Errors, Breaking Changes! May 24, 2017

benlesh mentioned this pull request May 24, 2017

Should we update to TypeScript 2.1 or 2.3 for v6 (beta to be released soon)? #2613

Closed

Merge branch 'master' into noEmitHelpers

094c8e0

benlesh mentioned this pull request May 25, 2017

Update TS: Alternative Error Fix #2614

Merged

benlesh closed this May 25, 2017

lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018

		@@ -1,4 +1,6 @@
		/* tslint:disable:no-unused-variable */
		import 'tslib';

Update to TypeScript 2.1, Update Errors, Breaking Changes! #2606

Update to TypeScript 2.1, Update Errors, Breaking Changes! #2606

Uh oh!

Conversation

benlesh commented May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Changes!!

Uh oh!

benlesh commented May 17, 2017

Uh oh!

kwonoj commented May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benlesh commented May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwonoj commented May 17, 2017

Uh oh!

kwonoj left a comment

Choose a reason for hiding this comment

Uh oh!

IgorMinar May 19, 2017

Choose a reason for hiding this comment

Uh oh!

IgorMinar May 19, 2017

Choose a reason for hiding this comment

Uh oh!

IgorMinar May 19, 2017

Choose a reason for hiding this comment

Uh oh!

benlesh May 24, 2017

Choose a reason for hiding this comment

Uh oh!

imcotton May 20, 2017

Choose a reason for hiding this comment

Uh oh!

benlesh May 24, 2017

Choose a reason for hiding this comment

Uh oh!

rxjs-bot commented May 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staltz commented May 24, 2017

Uh oh!

benlesh commented May 24, 2017

Uh oh!

benlesh commented May 25, 2017

Uh oh!

lock bot commented Jun 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

benlesh commented May 17, 2017 •

edited

Loading

kwonoj commented May 17, 2017 •

edited

Loading

coveralls commented May 17, 2017 •

edited

Loading

benlesh commented May 17, 2017 •

edited

Loading

rxjs-bot commented May 24, 2017 •

edited

Loading