Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mergeAll): introduce variant support <T, R> for mergeMap #2374

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Feb 14, 2017

Description:
This PR applies same type definition variant to concatAll (#1603) to mergeMap

Same as concatAll, note this doesn't provide auto-inference for types, only provides generic variant to explicitly specify types due to current design of typescript compiler.

Related issue (if exists):

@kwonoj
Copy link
Member Author

kwonoj commented Feb 14, 2017

/cc @Dorus for review.

@coveralls
Copy link

coveralls commented Feb 14, 2017

Coverage Status

Coverage remained the same at 97.68% when pulling 656f2b3 on kwonoj:style-mergeall into 25ee5b3 on ReactiveX:master.

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how we missed this before... >.>

@kwonoj kwonoj merged commit 02cbda6 into ReactiveX:master Feb 14, 2017
@kwonoj kwonoj deleted the style-mergeall branch February 14, 2017 21:16
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TS Typing] allow mergeAll on Observable<T[]> like mergeMap(x => x) allows
3 participants