fix(observeOn): remove observed subscription to clean up notification… #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
force-pushed
the
fix-observeon
branch
2 times, most recently
from
3e6ce97
to
686082d
Compare
… instance - relates to ReactiveX#2244
|
closing PR for now as this seems not legit fix and proper fix will follow. |
|
FYI: Fix PR is here #2248 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… instance
Description:
This PR updates internals of
observerOnto remove subscription once scheduled notification is observed. Wittout those, instance ofNotificationand relatedActionare hold by operator subscription and won't be freed. This is targeting master, as I believe there is no breaking changes.Related issue (if exists):