fix(root): find global context (window/self/global) in a more safe way

[jayphelps]

Fixes #1930

Unfortunately this isn't something we can really unit test AFAIK. It's pretty meta.

The objectTypes stuffs appeared to be a left over from earlier refactors cause none of these should ever be a function.

[coveralls]

Coverage decreased (-0.02%) to 97.113% when pulling 7d3dd70 on jayphelps:root into f63dde9 on ReactiveX:master.

[jayphelps]

ugh...remove code and even add one test and coverage goes down...wtf..

[kwonoj]

Seems coveralls complaining about missing coverage of throwing out if root nonexists. :/

https://coveralls.io/builds/7822965/source?filename=src%2Futil%2Froot.ts#L24

[jayphelps]

I can remove it....but it seems stupid to do so just to get coveralls from complaining. Thoughts or workarounds?

[kwonoj]

For this case I'd rather allow coverage decreasing. Thought way to test those cases bit, but wasn't able to find easy way to create legit coverage.

[kwonoj]

LGTM

[coveralls]

Coverage decreased (-0.02%) to 97.114% when pulling 9a4c306 on jayphelps:root into cd953b1 on ReactiveX:master.

[coveralls]

Coverage decreased (-0.02%) to 97.128% when pulling a098132 on jayphelps:root into 6bd3423 on ReactiveX:master.

[coveralls]

Coverage decreased (-0.02%) to 97.114% when pulling 9a4c306 on jayphelps:root into cd953b1 on ReactiveX:master.

[jayphelps]

@kwonoj planning to merge or waiting for others to chime in?

[kwonoj]

@jayphelps sorry, just too busy with new hire orientation all day long. Merged. :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.