Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Observable.ajax): change method to optional on interface, since… #1896

Merged
merged 4 commits into from
Sep 6, 2016

Conversation

elliotschi
Copy link
Contributor

Description:

Related issue (if exists):

… it gets set to GET by default

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.113% when pulling 01dfd7e on elliotschi:master into 8b60e8d on ReactiveX:master.

@kwonoj
Copy link
Member

kwonoj commented Aug 23, 2016

Change itself makes sense, only thing bit bothers me is since AjaxRequest is now completely optional interfaces, so AjaxObservable.create({}) is valid construction. Seems not an issue, just looking bit odd.

@kwonoj
Copy link
Member

kwonoj commented Aug 24, 2016

I wouldn't worry that much about AjaxObservable.create({}), change itself LGTM. Just will leave this opened bit more to see if there's any concerns around.

@elliotschi
Copy link
Contributor Author

@kwonoj sounds good

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.115% when pulling 09fb79e on elliotschi:master into 80b817f on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.115% when pulling 09fb79e on elliotschi:master into 80b817f on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.115% when pulling 35a5d43 on elliotschi:master into 7b23e88 on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.115% when pulling 0103940 on elliotschi:master into cb40e92 on ReactiveX:master.

@jayphelps
Copy link
Member

LGTM, please rebase.

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage remained the same at 97.115% when pulling 35a5d43 on elliotschi:master into 7b23e88 on ReactiveX:master.

@jayphelps jayphelps merged commit af4e6a9 into ReactiveX:master Sep 6, 2016
@kwonoj
Copy link
Member

kwonoj commented Sep 6, 2016

@jayphelps you're so fast, I was about to click merge btn and it was already merged! 💨

@jayphelps
Copy link
Member

👊 fastest merge in the West.

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants