fix(Notification): ensure do and observe handle partial observation
#1260
Conversation
- `do` will now handle notifying a handler that isn't present. (e.g. `notification.do(null, errorFn, null)`) - `observe` will now handle partial observers.
| @@ -11,11 +11,11 @@ export class Notification<T> { | |||
| observe(observer: Observer<T>): any { | |||
There was a problem hiding this comment.
type definition still requires observer interface, so typescript won't be able to pass partial implementation of observers. Should it be updated in this PR, or leave it for further type enhancement?
There was a problem hiding this comment.
Hmm... I thought I also had a PR to change the Observer interface to allow partials as well...
There was a problem hiding this comment.
Not yet, https://github.com/ReactiveX/RxJS/blob/master/src/Observer.ts#L3-L5 seems we may need those changes also. (better to include in this PR as one shot changes?)
There was a problem hiding this comment.
Just filed an issue related to this here: microsoft/TypeScript#6806
There was a problem hiding this comment.
This microsoft/TypeScript#4889 might be relevant to what we want?
|
Closing in favor of #1282 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
dowill now handle notifying a handler that isn't present. (e.g.notification.do(null, errorFn, null))observewill now handle partial observers.Relates to #1211...
Rather than enforce the shape of the Observer passed to
observe, we can allow any shape of Observer. If someone wants to use a generator as an observer passed toNotification.prototype.observeI see no reason to prevent them just because they don't haveerrororcompletefunctions.