Skip to content

Conversation

@robwormald
Copy link
Contributor

closes #1010

@kwonoj
Copy link
Member

kwonoj commented Dec 10, 2015

Just curiosity, what happens if delete all `.../add/*/.d.ts' ?

@robwormald
Copy link
Contributor Author

That works, but only until we bump up to TS 1.8 and patch the operator definition in the 'add' module.

On Dec 9, 2015, at 4:39 PM, OJ Kwon notifications@github.com wrote:

Just curiosity, what happens if delete all `.../add/*/.d.ts' ?


Reply to this email directly or view it on GitHub #1018 (comment).

@kwonoj
Copy link
Member

kwonoj commented Dec 10, 2015

Get it, thanks. (Just clarify, it wasn't suggestion to delete it, purely based on curiosity)

@robwormald
Copy link
Contributor Author

Yeah, I hadn't even considered that option, haha!

On Dec 9, 2015, at 4:44 PM, OJ Kwon notifications@github.com wrote:

Get it, thanks. (Just clarify, it wasn't suggestion to delete it, purely based on curiosity)


Reply to this email directly or view it on GitHub #1018 (comment).

@kwonoj
Copy link
Member

kwonoj commented Dec 10, 2015

I think changes good for immediate solution. (sorry, may require rebase due to my latest check in).

@robwormald
Copy link
Contributor Author

whoops, screwed up that merge. fixing...
oops

@benlesh
Copy link
Member

benlesh commented Dec 10, 2015

file mode changed

@robwormald
Copy link
Contributor Author

okay, good to go.

@kwonoj
Copy link
Member

kwonoj commented Dec 10, 2015

Cool, I'll check in in today once travis says good to go.

@kwonoj kwonoj merged commit 676f82d into ReactiveX:master Dec 10, 2015
@kwonoj
Copy link
Member

kwonoj commented Dec 10, 2015

Merged with 676f82d, appreciate @robwormald !

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type Definitions are empty for "add" modules

3 participants