Skip to content

fix(SymbolShim): ensure for function even if Symbol already exists #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2015
Merged

fix(SymbolShim): ensure for function even if Symbol already exists #1000

merged 2 commits into from
Dec 8, 2015

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Dec 8, 2015

In some engines, Symbol exists but does not impelment the for method.

fixes #999

@benlesh
fix(SymbolShim): ensure for function even if Symbol already exists
e942776 
In some engines, Symbol exists but does not impelment the for method.

fixes #999
@benlesh
fix(SymbolShim): Symbol polyfill is a function
1f57157 
Symbol is supposed to be a function that takes a description and returns a unique symbol
such that `Symbol('foo') !== Symbol('foo')`. The polyfill therefor returns a string that has
a unique identifier concatenated to it: `@@symbol(description):1` `@@symbol(description):2` etc

fixes #988
@benlesh
Copy link
Member Author

benlesh commented Dec 8, 2015

also fixes #988

@benlesh benlesh merged commit 1f57157 into ReactiveX:master Dec 8, 2015
@benlesh benlesh deleted the SymbolShim-issues branch April 27, 2016 17:14
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors with SymbolShim in some browsers
1 participant
@benlesh