Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v14: internal/types.d.ts(45,13): Property 'observable' does not exist on type 'SymbolConstructor'. #5861

Closed
orgads opened this issue Oct 27, 2020 · 0 comments · Fixed by #5874
Closed

Node v14: internal/types.d.ts(45,13): Property 'observable' does not exist on type 'SymbolConstructor'. #5861

orgads opened this issue Oct 27, 2020 · 0 comments · Fixed by #5874

Comments

@orgads
Copy link

orgads commented Oct 27, 2020

Bug Report

Current Behavior
Issue #3674 is resurrected with @types/node version 14.

Looks like it was removed in DefinitelyTyped/DefinitelyTyped#40927.

Environment

  • Runtime: Node v14
  • RxJS version: 6.6.3
@orgads orgads mentioned this issue Oct 27, 2020
Closed
10 tasks
orgads added a commit to orgads/rxjs that referenced this issue Oct 27, 2020
@orgads
fix(types): Add a missing import for Symbol.observable
cdfdc70 
This was reported previously on ReactiveX#3674, but instead of adding
this import, it was fixed in @types/node: DefinitelyTyped/DefinitelyTyped#26034.

This was removed in v14 of @types/node.

Fix it properly this time.

Fixes ReactiveX#5861
@orgads orgads mentioned this issue Oct 27, 2020
Closed
benlesh added a commit to benlesh/rxjs that referenced this issue Nov 2, 2020
@benlesh
fix(Symbol.observable): properly defined as a unique symbol.
727f775 
Resolves ReactiveX#5861
Resolves ReactiveX#4415
@benlesh benlesh mentioned this issue Nov 2, 2020
Merged
benlesh added a commit that referenced this issue Nov 2, 2020
@benlesh
fix(Symbol.observable): properly defined as a unique symbol. (#5874)
374138e 
Resolves #5861
Resolves #4415

BREAKING CHANGE: `rxjs@7` is only compatible with `@types/node@14.14.3` or higher and `symbol-observable@3.0.0` and heigher. Older versions of `@types/node` incorrectly defined `Symbol.observable` and will be in conflict with `rxjs` and `symbol-observable@3.0.0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Symbol.observable): properly defined as a unique symbol. benlesh/rxjs
1 participant
@orgads