fromEventPattern signal missing #1900
Comments
|
cc @trxcllnt |
|
@Blesh was I responsible for |
|
@trxcllnt no worries, it was an add you made very very early on in development. I can look at it too, I was just traveling when this crossed my screen. |
kwonoj
added a commit
to kwonoj/rxjs
that referenced
this issue
Dec 28, 2016
…Handler - relates to ReactiveX#1900
kwonoj
added a commit
to kwonoj/rxjs
that referenced
this issue
Jan 5, 2017
…Handler - relates to ReactiveX#1900
kwonoj
added a commit
to kwonoj/rxjs
that referenced
this issue
Jan 15, 2017
…Handler - relates to ReactiveX#1900
|
Closing via #2224. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
RxJS version: 5.0.0-beta.11
In v4, there was a way to take the signal (the thing returned from
addHandler) and use it inremoveHandlerfor proper disposal. See v4 docs forfromEventPattern, under the Dojo toolkit example. I think this functionality is still useful and it appears to be missing.I can attempt to submit a PR, but I was wondering if there was a reason for its removal.
The text was updated successfully, but these errors were encountered: