refactor(shareReplay): align logic with var names (#2919)

Change isComplete from being always true to representing whether or not the source is actually complete.
ReactiveX · Oct 9, 2017 · 4dc73e4 · 4dc73e4
1 parent f55bfa5
commit 4dc73e4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/operators/shareReplay.ts b/src/operators/shareReplay.ts
@@ -12,7 +12,7 @@ export function shareReplay<T>(bufferSize?: number, windowTime?: number, schedul
   let refCount = 0;
   let subscription: Subscription;
   let hasError = false;
-  let isComplete = true;
+  let isComplete = false;
 
   return (source: Observable<T>) => new Observable<T>(observer => {
     refCount++;
@@ -37,7 +37,7 @@ export function shareReplay<T>(bufferSize?: number, windowTime?: number, schedul
     return () => {
       refCount--;
       innerSub.unsubscribe();
-      if (subscription && refCount === 0 && !isComplete) {
+      if (subscription && refCount === 0 && isComplete) {
         subscription.unsubscribe();
       }
     };