chore: Update to valid, active Node versions (#7127)

We had an issue where older, unsupported node versions were choking on the npm install script for latest npm. We needed to update our node versions
ReactiveX · Dec 3, 2022 · 054c0d3 · 054c0d3
1 parent 51e3b2c
commit 054c0d3
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 42 deletions.
diff --git a/.github/workflows/ci_main.yml b/.github/workflows/ci_main.yml
@@ -6,39 +6,37 @@ on:
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ '12', '13', '14', '15', '16' ]
+        node: ['14', '16', '18']
 
     name: Node ${{ matrix.node }} build
 
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node }}
-    - name: install
-      run: |
-        npm install -g npm@latest
-        npm ci
-    - name: lint
-      run: npm run lint
-    - name: build
-      run: npm run build:package
-    - name: test
-      run: |
-        npm test
-        npm run test:side-effects
-    - name: dtslint
-      run: npm run dtslint
-    - name: api_guardian
-      run: npm run api_guardian
-    - name: import
-      if: ${{ matrix.node == '14' }}
-      run: npm run test:import
-    - name: import
-      if: ${{ matrix.node == '14' || matrix.node == '15' }}
-      run: npm run test:esm
-
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node }}
+      - name: install
+        run: |
+          npm install -g npm@latest
+          npm ci
+      - name: lint
+        run: npm run lint
+      - name: build
+        run: npm run build:package
+      - name: test
+        run: |
+          npm test
+          npm run test:side-effects
+      - name: dtslint
+        run: npm run dtslint
+      - name: api_guardian
+        run: npm run api_guardian
+      - name: import
+        if: ${{ matrix.node == '14' }}
+        run: npm run test:import
+      - name: import
+        if: ${{ matrix.node == '14' || matrix.node == '15' }}
+        run: npm run test:esm
diff --git a/.github/workflows/ci_ts_latest.yml b/.github/workflows/ci_ts_latest.yml
@@ -6,23 +6,21 @@ on:
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ '14' ]
+        node: ['18']
 
     name: ts@latest
 
     steps:
-    - uses: actions/checkout@v2
-    - uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node }}
-    - name: build
-      run: |
-        npm install -g npm@latest
-        npm ci
-        npm install --legacy-peer-deps --no-save typescript@latest tslib@latest @types/node@latest
-        npm run compile
-
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node }}
+      - name: build
+        run: |
+          npm install -g npm@latest
+          npm ci
+          npm install --legacy-peer-deps --no-save typescript@latest tslib@latest @types/node@latest
+          npm run compile