4.x: Streamable, improved range and collect internals + JMH#8235
Open
akarnokd wants to merge 1 commit into
Open
4.x: Streamable, improved range and collect internals + JMH#8235akarnokd wants to merge 1 commit into
akarnokd wants to merge 1 commit into
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.687 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (80.48%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8235 +/- ##
============================================
+ Coverage 98.69% 98.71% +0.01%
- Complexity 7146 7151 +5
============================================
Files 822 822
Lines 50375 50405 +30
Branches 6819 6825 +6
============================================
+ Hits 49719 49755 +36
+ Misses 457 450 -7
- Partials 199 200 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
range improvement
By removing the double tracking and volatile, we are saving 100 cycles per item.
collect improvements
nextinvocation, saving 50 cycles per item.nextreturned a completed stage and extracting the value from it is faster than going through thewhenCompletecallback which allocates an otherwise unused stage for its return.IndexableSourcethat can access trivially available or computable elements via index.These enhancements will be transplanted to similar operators to help synchronous islands perform better.
📓 At one point, it was considered to use a similar indexer access in
FlowableandObservableoperator fusion but benchmarks yielded equal performance with the existing optimizations within an error bar so it was not pursued further.Streamables reliance of theCompletionStageinfrastructure is huge overload for basic synchronous sequences.