ScheduledRunnable to honor interrupt settings from Schedulers.from usage#7745
Merged
akarnokd merged 1 commit intoReactiveX:3.xfrom Aug 10, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #7745 +/- ##
=========================================
Coverage 99.62% 99.63%
- Complexity 6801 6803 +2
=========================================
Files 752 752
Lines 47707 47710 +3
Branches 6401 6402 +1
=========================================
+ Hits 47527 47534 +7
+ Misses 84 79 -5
- Partials 96 97 +1 ☔ View full report in Codecov by Sentry. |
vanniktech
approved these changes
Aug 10, 2024
stlcwb
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
Schedulers.fromand running a delayed task viaschedule(Runnable, long, TimeUnit), theExecutorScheduleruses the standardScheduledRunnableinfrastructure for the initial delay.When the task is disposed during this initial delay, the cancellation always triggers with an interrupted on inside
ScheduledRunnableas it is not aware theSchedulers.frommay run in no-interrupt mode.When the dispose happens after the delay, during the actual task's runtime, the no-interrupt mode is honored as expected (as
ScheduledRunnableis no longer involved).This PR adds an
interruptOnCancelflag toScheduledRunnable, an overloaded constructor to minimize the change impact and several tests that check for the aforementioned situations.Resolves #7744