ScheduledRunnable to honor interrupt settings from Schedulers.from usage #7745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Schedulers.from
and running a delayed task viaschedule(Runnable, long, TimeUnit)
, theExecutorScheduler
uses the standardScheduledRunnable
infrastructure for the initial delay.When the task is disposed during this initial delay, the cancellation always triggers with an interrupted on inside
ScheduledRunnable
as it is not aware theSchedulers.from
may run in no-interrupt mode.When the dispose happens after the delay, during the actual task's runtime, the no-interrupt mode is honored as expected (as
ScheduledRunnable
is no longer involved).This PR adds an
interruptOnCancel
flag toScheduledRunnable
, an overloaded constructor to minimize the change impact and several tests that check for the aforementioned situations.Resolves #7744