Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @NonNull to the methods of Emitter #5156

Merged
merged 1 commit into from
Mar 5, 2017

Conversation

hkurokawa
Copy link
Contributor

@hkurokawa hkurokawa commented Mar 5, 2017

This PR is a part of #4876

This PR adds @NonNull annotation to some methods of Emitter so that the users of RxJava migrating from 1.x to 2.x can easily know passing null to the methods will cause NPE.

@hkurokawa
Copy link
Contributor Author

Sorry, I've just noticed there is #5151 related to this PR.

@akarnokd akarnokd modified the milestones: 2.0 backlog, 2.1 Mar 5, 2017
@codecov
Copy link

codecov bot commented Mar 5, 2017

Codecov Report

Merging #5156 into 2.x will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #5156      +/-   ##
============================================
+ Coverage     95.88%   95.91%   +0.02%     
+ Complexity     5606     5601       -5     
============================================
  Files           620      620              
  Lines         39856    39856              
  Branches       5604     5604              
============================================
+ Hits          38217    38227      +10     
+ Misses          654      651       -3     
+ Partials        985      978       -7
Impacted Files Coverage Δ Complexity Δ
...ternal/operators/flowable/FlowableSubscribeOn.java 90.9% <0%> (-5.46%) 2% <0%> (ø)
...rnal/subscribers/SinglePostCompleteSubscriber.java 94.87% <0%> (-5.13%) 14% <0%> (-1%)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <0%> (-4.62%) 27% <0%> (-1%)
...internal/operators/completable/CompletableAmb.java 94.44% <0%> (-3.71%) 10% <0%> (-1%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 91.92% <0%> (-3.14%) 10% <0%> (+1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.53% <0%> (-2.99%) 2% <0%> (ø)
...activex/internal/operators/single/SingleCache.java 97.05% <0%> (-2.95%) 23% <0%> (-1%)
...x/internal/operators/maybe/MaybeSwitchIfEmpty.java 97.22% <0%> (-2.78%) 2% <0%> (ø)
...activex/internal/disposables/DisposableHelper.java 98.14% <0%> (-1.86%) 27% <0%> (-1%)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26eff79...22e8735. Read the comment docs.

@akarnokd
Copy link
Member

akarnokd commented Mar 5, 2017

Thanks @hkurokawa for the PR and @vanniktech for the review!

@akarnokd akarnokd merged commit b41ac3b into ReactiveX:2.x Mar 5, 2017
@hkurokawa
Copy link
Contributor Author

@vanniktech @akarnokd Thank you for your prompt merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants