2.x: fix Single.takeUntil() other triggering twice #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.60% (diff: 100%)@@ 2.x #4962 diff @@
==========================================
Files 587 587
Lines 37669 37671 +2
Methods 0 0
Messages 0 0
Branches 5675 5676 +1
==========================================
Hits 36016 36016
- Misses 693 704 +11
+ Partials 960 951 -9
|
JakeWharton
approved these changes
Jan 6, 2017
This was referenced Jan 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the double termination of
Single.takeUntil(Publisher)when theotherfires an item and then completes while ignoring the cancellation in between, trying to signal aCancellationExceptionagain which is routed to theRxJavaPlugins.onErrorand crashing on Android.In addition, the
Maybe.takeUntil()received a unit test verifying this doesn't also happen to it.Related: #4961.