2.x: add safeguards to generate() #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.60% (diff: 95.45%)@@ 2.x #4932 diff @@
==========================================
Files 587 587
Lines 37519 37540 +21
Methods 0 0
Messages 0 0
Branches 5644 5652 +8
==========================================
+ Hits 35866 35889 +23
+ Misses 705 699 -6
- Partials 948 952 +4
|
smiklos
reviewed
Dec 20, 2016
| } | ||
|
|
||
| @Test | ||
| public void multipleOnComlete() { |
JakeWharton
approved these changes
Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flowable.generate()andObservable.generate()lacked the safeguards that were present in 1.x. This adds those and adds extra state cleanup.Related: #4931