-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use t instead of value to allow for IDE naming #4907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Does 2.x need this?
This is for 2.X. Did I make a mistake? I could add this to 1.X also if desired. |
Hah, yeah I meant 1.x. Off-by-one error. |
#4908 Surprisingly it was already done a lot more in 1.x, so there were only a few cases I found. |
Current coverage is 95.70% (diff: 100%)@@ 2.x #4907 diff @@
==========================================
Files 586 586
Lines 37410 37410
Methods 0 0
Messages 0 0
Branches 5628 5628
==========================================
+ Hits 35792 35803 +11
+ Misses 673 665 -8
+ Partials 945 942 -3
|
Naming the value
t
instead ofvalue
allows the IntelliJ to intelligently name the variable based on the type when autocompleting.Before:
After: