Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Add Single.fromObservable(ObservableSource) #4760

Merged
merged 2 commits into from
Oct 24, 2016
Merged

2.x: Add Single.fromObservable(ObservableSource) #4760

merged 2 commits into from
Oct 24, 2016

Conversation

vanniktech
Copy link
Collaborator

  • adds an overload to create a Single from an ObservableSource

vanniktech
vanniktech commented Oct 24, 2016
View reviewed changes
src/test/java/io/reactivex/single/SingleTest.java
@@ -22,6 +22,7 @@
import org.junit.*;

import io.reactivex.*;
import io.reactivex.Observable;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to add this import otherwise:

SingleTest.java:562: error: reference to Observable is ambiguous Single.fromObservable(Observable.just(1))

@akarnokd akarnokd merged commit 699e8e9 into ReactiveX:2.x Oct 24, 2016
@vanniktech vanniktech deleted the 2.x_single_from_observable branch October 24, 2016 13:59
@akarnokd akarnokd added this to the 2.0 milestone Oct 24, 2016
@akarnokd akarnokd mentioned this pull request Oct 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarnokd akarnokd akarnokd approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vanniktech @akarnokd