2.x: cleanup, fixes, coverage 10/20-1 #4736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.98% (diff: 91.16%)@@ 2.x #4736 diff @@
==========================================
Files 569 569
Lines 37209 37197 -12
Methods 0 0
Messages 0 0
Branches 5672 5674 +2
==========================================
+ Hits 34177 34587 +410
+ Misses 1757 1436 -321
+ Partials 1275 1174 -101
|
JakeWharton
approved these changes
Oct 20, 2016
| * A reduce should fail with an NoSuchElementException if done on an empty Observable. | ||
| */ | ||
| @Test(expected = NoSuchElementException.class) | ||
| @Test |
There was a problem hiding this comment.
Shouldn't the body of this test change too? Maybe to test().assertComplete() or whatever?
There was a problem hiding this comment.
Yeah, .assertResult() would be more apt here. Will do in the next batch.
vanniktech
reviewed
Oct 20, 2016
| } | ||
|
|
||
| @Test | ||
| public void slowPathRebatch() { |
There was a problem hiding this comment.
how is this one different from the one above?
There was a problem hiding this comment.
Copy-paste error, should not have filter there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observableoperators to a reasonable level (the remaining are either impossible or only reachable by probabilistic race)ObservableandFlowableFlowableoperatorsFlowableoperators (cache, concatMap)onBackpressureBuffer(long, Action, BufferOverflowStrategy)return typeconcatMapDelayErrorwrong barrier mode selected