Skip to content

2.x: Remove unused methods in BasicFuseableObserver #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2016
Merged

2.x: Remove unused methods in BasicFuseableObserver #4637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions src/main/java/io/reactivex/internal/observers/BasicFuseableObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import io.reactivex.disposables.Disposable;
import io.reactivex.exceptions.Exceptions;
import io.reactivex.internal.disposables.DisposableHelper;
import io.reactivex.internal.functions.ObjectHelper;
import io.reactivex.internal.fuseable.QueueDisposable;
import io.reactivex.plugins.RxJavaPlugins;

Expand Down Expand Up @@ -91,17 +90,6 @@ protected void afterDownstream() {
// Convenience and state-aware methods
// -----------------------------------

/**
* Emits the value to the actual subscriber if {@link #done} is false.
* @param value the value to signal
*/
protected final void next(R value) {
if (done) {
return;
}
actual.onNext(value);
}

@Override
public void onError(Throwable t) {
if (done) {
Expand Down Expand Up @@ -131,16 +119,6 @@ public void onComplete() {
actual.onComplete();
}

/**
* Checks if the value is null and if so, throws a NullPointerException.
* @param value the value to check
* @param message the message to indicate the source of the value
* @return the value if not null
*/
protected final <V> V nullCheck(V value, String message) {
return ObjectHelper.requireNonNull(value, message);
}

/**
* Calls the upstream's QueueDisposable.requestFusion with the mode and
* saves the established mode in {@link #sourceMode}.
Expand Down